Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update control_plane.rst doc #1229

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

Ln11211
Copy link
Contributor

@Ln11211 Ln11211 commented Oct 7, 2022

TL;DR

This PR updated the control_plane.rst doc

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Updated the note and removed the bullet point.

Tracking Issue

#1212 (comment)

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Removed the bullet point and updated note.


Signed-off-by: LN <[email protected]>
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1229 (8e4e2f4) into master (3d008e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1229   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         288      288           
  Lines       26279    26279           
  Branches     2935     2935           
=======================================
  Hits        18036    18036           
  Misses       7764     7764           
  Partials      479      479           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

removed stray colon

Signed-off-by: LN <[email protected]>
@Ln11211
Copy link
Contributor Author

Ln11211 commented Oct 7, 2022

image

@samhita-alla, how does this look?

@eapolinario eapolinario merged commit 13319cb into flyteorg:master Oct 7, 2022
VPraharsha03 pushed a commit to VPraharsha03/flytekit that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants